search

davidedmundson / xembed-sni-proxy

Convert XEmbed system tray icons to SNI icons
GNU General Public License v2.0
32 stars 6 forks source link

Scale icons by QT_DEVICE_PIXEL_RATIO #7

Closed ephemient closed 8 years ago

ephemient commented 8 years ago

No clue if this is the right thing to do, but it definitely makes things look nicer on my system (dpi is set to 192). Otherwise the xembed icons look freakishly small next to the SNI ones.

davidedmundson commented 8 years ago

I don't see how this makes a difference.

Here we're just scaling before sending, but in the client (in Plasma) the icon will be scaled too.

ephemient commented 8 years ago

Maybe that should happen, but it didn't in practice. The 24x24 image being sent across before was being displayed as a little dot centered between normal-sized icons.

davidedmundson commented 8 years ago

Then that needs fixing. Otherwise we'll have the same problem when an app using SNI directly sends a low res pixmap.

From what I can see the pixmap is sent verbatim to a PlasmaCore.IconItem - which should scale any pixmap set as the source.

davidedmundson commented 8 years ago

Could you try with latest master. I put in a fix for chromium

FadeMind commented 8 years ago

@davidedmundson after install lastest git commit default dropbox icon looking: a

ephemient commented 8 years ago

Yeah I think the "problem" I had was just Chromium acting suspiciously different on first embed versus after restarting xembedsniproxy or something like that, the appearance at HEAD is fine now. Still encountering #2 but this PR is irrelevant.