search

davideicardi / live-plugin-manager

Plugin manager and installer for Node.JS
MIT License
225 stars 43 forks source link

handle peerDependencies #35

Open davideicardi opened 3 years ago

davideicardi commented 3 years ago

If when installing a package we found that there is one or more peerDependencies not available inside staticDependencies throw an error.

From #24 :

Installing peerDependencies automatically would be unexpected for people who are used to NPM/Yarn behavior. From my understanding, it seems like staticDependencies could play well with peerDependencies. For example:

  • package A specifies peer dependency X
  • my project installs & requires package A using live-plugin-manager
  • live-plugin-manager will not install X
  • (new behavior) if my project does not pass X via staticDependencies, live-plugin-manager will error or warn (just my 2 cents)
ylc395 commented 2 years ago

What about add an option to install peerDependencies?

davideicardi commented 2 years ago

@ylc395 Yes agree, it could be an option.