search

davideicardi / live-plugin-manager

Plugin manager and installer for Node.JS
MIT License
233 stars 44 forks source link

support repository specified as git:// #6

Closed iurimatias closed 4 years ago

davideicardi commented 6 years ago

Thanks @iurimatias for your pull request. May I ask you to implement this feature changing the .ts files? I have written all the source code using Typescript, .js are just compiled files.

To compile from typescript you just need to run

npm install
npm run src-build

You can then run npm test to check if everything works correctly, eventually by also adding some new unit tests.

thanks!

iurimatias commented 6 years ago

@davideicardi sorry my bad, I didn't notice :D

davideicardi commented 6 years ago

Thanks!

Your change assume that repository is hosted on github right?

iurimatias commented 6 years ago

hi @davideicardi , I somewhat only noticed your comment now... so far as I remember this change was a fix due to live-plugin-manager crashing with git references, I don't recall if it was specific to github or not..

davideicardi commented 4 years ago

Closing for inactivity for now. Created an issue to track the request at #26