davideicardi / live-plugin-manager

Plugin manager and installer for Node.JS
MIT License
242 stars 44 forks source link

Error: Invalid plugin github repository #70

Open testdrivendavid opened 2 years ago

testdrivendavid commented 2 years ago

Hi.

Im trying to use the live-plugin-manager library to load my custom-made module(Typescript) from a public github repo during runtime. But it errors with the following:

/Users/david/WebstormProjects/send_help/node_modules/live-plugin-manager/dist/src/GithubRegistryClient.js:67
                throw new Error("Invalid plugin github repository " + repository);
                      ^

Error: Invalid plugin github repository dnhook123/modules#25c265c
    at GithubRegistryClient.<anonymous> (/Users/david/WebstormProjects/send_help/node_modules/live-plugin-manager/dist/src/GithubRegistryClient.js:67:23)
    at Generator.next (<anonymous>)
    at fulfilled (/Users/david/WebstormProjects/send_help/node_modules/live-plugin-manager/dist/src/GithubRegistryClient.js:24:58)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
import {PluginManager} from 'live-plugin-manager';
const manager = new PluginManager();

const test = await manager.queryPackageFromGithub('dnhook123/modules#25c265c');

Index.js code

I've already found out that the github repo's like express.js works but mine do not. Do you know perhaps why?

My github error example: example error The module i want to load in module

testdrivendavid commented 2 years ago

Because i have a custom made ts module that i want to import during runtime, do you perhaps know what are the requirements for being able to import such module (from github)?

testdrivendavid commented 2 years ago

Another random question, can this library run .TS files (index.ts) aswell?