search

davideicardi / live-plugin-manager

Plugin manager and installer for Node.JS
MIT License
242 stars 44 forks source link

Add Bitbucket support #71

Closed quarenw closed 2 years ago

quarenw commented 2 years ago

This PR adds support to install packages from Bitbucket both public and private only using Basic auth.

Tests added for inexistant packages and public package. The package used in the public test is from Atlassian but is quite big and takes a long time to run the test. Was not able to find a better package hosted on Bitbucket which is reliable and immediately usable for use in the test.

Private repos is tested and working but as with Github it has not been added to the tests.

My use case for adding this feature is installing private Bitbucket packages from master branch and there is no testing for different branches/commits refs but will be adding it in the future.

quarenw commented 2 years ago

Thank you for the review! Makes sense, updated to use a simple package on Bitbucket. Tests now run a reasonable amount of time.

davideicardi commented 2 years ago

I see that a test abount concurrency installation has failed. Do you think this can be related to your changes? I don't think so but I need to investigate ...

quarenw commented 2 years ago

I don't think it is related. I have only gotten it to fail once when I run it but am not able to reproduce it when running it myself. Looking at the Actions logs it looks like it has failed previously, before tthe Bitbucket additions, for the same reasons: https://github.com/davideicardi/live-plugin-manager/runs/5721846444?check_suite_focus=true

image image

Though in that case node 14 and 12 tests were run while in this last run they were instead cancelled because 16 failed.

Looking at the tests I am not sure why there is the file '/home/runner/work/live-plugin-manager/live-plugin-manager/plugin_packages/install.lock' causing the test to error as I cannot reproduce. Will see if I can replicate.

davideicardi commented 2 years ago

Still failing ... strange issue. I will try to investigate.

quarenw commented 2 years ago

Had some time to test and put in a PR for a change to the locking test: https://github.com/davideicardi/live-plugin-manager/pull/72

davideicardi commented 2 years ago

I will merge this PR given that the error seems to be unrelated to the change. We can try to fix it in #72 Thank you!