search

davideloba / daliMaster

Control your lamps with a Dali shield for Arduino™
MIT License
46 stars 12 forks source link

When using group, group is always 0, no matter what group-number is used. #3

Open rudydevolder opened 4 years ago

rudydevolder commented 4 years ago

Actually I found the solution myself: But I never used Github to correct something. David maybe you can help me with that? I need to fork first and than correct? The fault is in: "dalimaster.cpp" 

uint8_t DALIMASTER::setGroupAddress(uint8_t group, uint8_t mode){
    //Wrong code: 
        //return (0x80 | ((group & 16) << 1) | mode);
      return (0x80 | ((group & 15) << 1) | mode);         //This works
}