search

davidepatti / noxim

Network on Chip Simulator
218 stars 118 forks source link

fix: use cmake --build for macOS install script #153

Closed inventor02 closed 6 months ago

inventor02 commented 6 months ago

If the CMAKE_GENERATOR is set to anything other than Unix Makefiles, the macOS install script fails, as it is hardcoded to use make regardless of the CMake setting.

CMake has a solution for this in the form of cmake --build, which uses the generator that was used when CMake was executed.

This PR implements this for the yaml-cpp build; the rest of the components do not use CMake and are provided with Makefiles, so work correctly.

(aside: I happen to know the person who wrote the original script - it is a small world!)

davidepatti commented 6 months ago

I merged the pull request thinking it was working, but I'm noticing that I'm getting a "cmake not found message, while I have the make command that was previously used in the script.

inventor02 commented 6 months ago

That's strange - cmake is used on the line before the one I changed (and has always been there) so I think this is a requirement to build yaml-cpp

davidepatti commented 6 months ago

yes, your're right. I wasn't compiling noxim on macos in the recent month, so I forgot that cmake is not included by default. Anyway I think any noxim user will be able to meet this dependency on cmake, thanx for the fix.