search

davidepianca98 / KMQTT

Kotlin Multiplatform MQTT client & embeddable and standalone broker
MIT License
188 stars 29 forks source link

TLSClientSettings from String instead of file path #41

Closed edouardouvrard closed 8 months ago

edouardouvrard commented 8 months ago

Do you think there will be a possibility to make all file path based settings for TLSClientSettings to have also a String based settings ? I know it's possible on JVM based platform but i don't know if other platform can take a String argument ?

public data class TLSClientSettings(
    val version: String = "TLS",
    val serverCertificatePath: String? = null,
    val clientCertificatePath: String? = null,
    val clientCertificateKeyPath: String? = null,
    val clientCertificatePassword: String? = null
)
davidepianca98 commented 8 months ago

Hello, thanks for proposing this enhancement. I will check if it is possible and if it is I will implement it.

edouardouvrard commented 8 months ago

Let me know if i can help.

davidepianca98 commented 8 months ago

Added in https://github.com/davidepianca98/KMQTT/commit/5ee298c453916f372847e622a8606c2d4835890e. I hope to make a new release in the next few days.

edouardouvrard commented 8 months ago

Thanks @davidepianca98 for the feature, do you have an eta for the new release ?

davidepianca98 commented 8 months ago

Sorry it took this long, I had a few problems. The release 0.4.6 is now available.

edouardouvrard commented 8 months ago

Thanks @davidepianca98