davideshay / groceries

MIT License
221 stars 7 forks source link

Feedback #125

Open Pieeeeeee opened 7 months ago

Pieeeeeee commented 7 months ago

I can't find another way to give feedback, so creating a new issue for it.

Just wanted to let you know my first impression, in case you're still planning improvements in the future. First impression was: it's more complicated than I thought it would be. It has a bit of a learning curve, which might hold my gf back of using it. Things that I think can improve:

Other things that might be handy:

Don't know if this is a bug, but I'll mention it: With setting "Don't add automatically", when completing an item, it is completed in all lists of the list group (which is correct). Then when you add that same item again in a single list (without removing it first), it is also added in the other lists of the list group.

davideshay commented 7 months ago

I can't find another way to give feedback, so creating a new issue for it.

All good.

Just wanted to let you know my first impression, in case you're still planning improvements in the future. First impression was: it's more complicated than I thought it would be. It has a bit of a learning curve, which might hold my gf back of using it. Things that I think can improve:

  • you can't delete or change the default categories or UoM. English is not my first language, so I'd like to change or delete everything. Now you can only deselect categories in stead of deleting them (or changing the name). Unless I'm missing something, UoM can't even be deselected.

Translations built-in for German and Spanish. What language are you wanting to use? I can auto-generate some initial translations and happy to accept additional localizations.

  • When adding a new item, you have to give a quantity and UoM. That quantity and UoM stays there, even if you marked it as completed and removed it. Next time you add the item, same quantity and UoM is added with it. I wonder why there is no plus and minus button next to every item in the list overview. Having to edit the item, which opens a new page, to change the quantity is not very user friendly. A perfect solution would be: choose which UoM are applicable for an item, and select a default. In the list, have a + and - button for every item to adjust the quantity, and a dropdownlist with the applicable UoM available for that item, with the default pre-selected. For example you can buy a single tomato, or 1 package containing multiple tomatoes.

Screen real-estate certainly becomes an issue with putting +/- on the item check-off screen. I can see what might be possible here. I understand the request for different "allowable" UOMs per item, but I don't know that this is a very common use case. If you find yourself frequently adding 1 tomato and 1 package to the list, you could create two different items each with a different pre-set UOM.

  • Same for the notes. When you add a note to an item, it is always there when adding the item. While I think a note is a temporarily thing. For example my gf might add the item "raspberries", and add a note "look for the fresh ones!", as she always says irl. Also the note is only readable when you edit the item, it would be better if the note was visible in the list overview. Possibly with an arrow to expand/collapse the item if the note is too long.

I guess we've mostly found the notes apply on an ongoing basis. Again due to real-estate, what I've added is a note icon for those items that have a note. I could perhaps see if clicking on the note would popup just the note onto the screen. Will have to see if that would work.

  • You can't add the same item multiple times. Say I want 2 breads: one white and one brown. Do you need to create two different items for it?

Yes, in this case I'd add White Bread as one item and Brown Bread as another.

  • Why does a UoM need a Code (ISO)? What use do alternate UoM abbreviations have? I added one for testing purposes, but can't find it anywhere. Bug: when editing a predefined UoM, you can add an abbreviation, but can't save it.

Probably a poor design decision... I used the ISO codes as an effective "key" or 2 character code for each UOM. When you are adding your own, you don't have to use an ISO code, but it is still limited to 2 characters.

The alternate UOMs are really only used when importing recipes from Tandoor in order to map correctly -- not needed for anything else.

I do see a bug when adding abbreviations on global UOMs -- I'll fix that.

  • The default api url on the login screen is not changeable. It always says "https://groceries.mydomain.com/api". For the self hosted WebUI it would be better if you can't even see or change it, and define the url in configuration.

This should only have to be changed once, then it is stored in local storage on web page or on phone. If you want to default even this first entry, you can add to env-config.js in the client directory, and it will get baked into the web server when you build it.

  • Logging in isn't triggered when pressing enter. It only works when specifically clicking the login button.

I've noticed that as well. Will look into it and see how to change.

Other things that might be handy:

  • in the Items overview, add a delete button next to each item

Will look at it - I think it's usually "safer" to look at the detail before deleting it, understand which list groups it's on, etc.

  • in the settings, add a info button next to the "add to other list options", which gives a popup or opens the userguide to the correct setting. These settings are not self explanatory so had to look it up.

Will see what the best way to do is.

  • merge the pages "Manage All Items" and "View Global Items", and make global items editable.

The reason global items aren't editable is a bit complex. In my household, for example, I have people in 3 different geographies/households using the app. The problem could be that one person changes the name to "Ripe Bananas" that not everyone would want to apply to their list. This one is fairly well built in to the architecture and likely won't change.

Don't know if this is a bug, but I'll mention it: With setting "Don't add automatically", when completing an item, it is completed in all lists of the list group (which is correct). Then when you add that same item again in a single list (without removing it first), it is also added in the other lists of the list group.

Let me try to replicate. I may already be working on a similar bug.

Pieeeeeee commented 7 months ago

Hi I am Dutch. I started translating the translations.ts file myself to provide it to you, but after 140 lines decided it's too much work. It's mostly the build-in categories, global items and UoM that are a bit in the way. Even if they would be translated, a lot of them I wouldn't use. I temporarily fixed it by deleting all docs from the DB that start with "system:". Some feedback on that procedure: logging out didn't clean the local data. You have to specifically use the "delete local data" button.

In the list view, maybe there can be an expand button (down arrow) that expands the item so you can read the note and have + and - buttons to adjust the quantity. To add UoM, I started using "AA", "AB" as ISO code, because sometimes the ISO code is already in use. The popup when adding a UoM via Editing Item is confusing. First field says "Name", where you should fill in the ISO code.

Editing the categories of a shop is a bit buggy.

Lastly the first reaction of my gf when letting her install the app: "Isn't there another one, this one looks boring. It's all grey". For the self hosted UI I can change the css. But I can't change css in the apk.

kladderadeng commented 5 months ago

Don't know if this is a bug, but I'll mention it: With setting "Don't add automatically", when completing an item, it is completed in all lists of the list group (which is correct). Then when you add that same item again in a single list (without removing it first), it is also added in the other lists of the list group.

We have this too sometimes, but whenever we tried to replicate it on purpose, we could not. So I never created an issue for that. It happens very rarely for us, but as you describe it, it might be related to the settings somehow. I was not able to figure it out yet.