search

davideuler / gitblit

Automatically exported from code.google.com/p/gitblit
Apache License 2.0
0 stars 0 forks source link

Disabling charts still makes external requests #310

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Set web.generateActivityGraph = false
2. Observe that graphs are still generated

What is the expected output? What do you see instead?
Graphs are still shown. Graphs should be disabled.

What version of the product are you using? On what operating system?
1.4.0-SNAPSHOT (6de9531)

Please provide any additional information below.
Ideally it'd be nice to generate these graphs without making external requests 
to a third party site (and I believe the Charts API is deprecated :().

Original issue reported on code.google.com by choro...@wikimedia.org on 18 Sep 2013 at 6:31

GoogleCodeExporter commented 9 years ago 
Setting web.generateActivityGraph DOES disable graphing.  I just re-confirmed.

You might be getting faked-out by use of caching.

Original comment by James.Mo...@gmail.com on 19 Sep 2013 at 12:19

GoogleCodeExporter commented 9 years ago 
Ah.  When that setting was created, only the Summary page and the Metrics page 
had graphs.  I just pushed a change that makes the Dashboard and Activity pages 
obey the same setting.  So I guess we were both right.  :)

As for replacing the charting package... that is a (likely) possibility.  I 
have gotten several complaints about wanting to run in an isolated network.  
Unfortunately, Google doesn't allow offline use of their API so I would have to 
completely replace it.  :(

Original comment by James.Mo...@gmail.com on 19 Sep 2013 at 12:41

GoogleCodeExporter commented 9 years ago 
1.4.0 released.

Original comment by James.Mo...@gmail.com on 9 Mar 2014 at 6:06