search

davideuler / gitblit

Automatically exported from code.google.com/p/gitblit
Apache License 2.0
0 stars 0 forks source link

Deleting the LDAP mail attribute doesn't delete the Gitblit user's mail attribute #456

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
If the mail attribute is empty in LDAP and then I fill it and re-login on the 
web UI (which apparently triggers fetching the account details) it updates the 
Gitblit user's mail attribute accordingly, but if I do it the other way around 
i.e. the LDAP mail attrib is already filled and I erase it the Gitblit mail 
attribute will not go away.

I'm pretty sure it's not a cache problem coz the user's LDAP attrib's been 
empty for weeks and Gitblit's been restarted several times ever since. The old 
mail attrib's still present in Gitblit.

If I delete the mapped Gitblit user and re-login, the user will appear in the 
Gitblit user list without the mail address, as it should.

Also, if I add just a simple character to the LDAP mail attrib Gitblit will 
change the Gitblit user's mail attrib to that right away. So it seems like an 
unnecessary check somewhere in the code.

Original issue reported on code.google.com by sundayfu...@outlook.com on 2 Jul 2014 at 12:02

GoogleCodeExporter commented 9 years ago 
I forgot to add that I'm running 1.6.1-SNAPSHOT (8c0c9ae48f).

Original comment by sundayfu...@outlook.com on 2 Jul 2014 at 12:13

GoogleCodeExporter commented 9 years ago 
Hopefully fixing this for you doesn't generate complaints from other LDAP 
users.  LDAP is one of the few parts of Gitblit that is a little voodoo for me. 
 I don't run LDAP and it is sooo flexible/configurable that it is easy to make 
something work for one group and break others.  :/

This *should* be just a straight-forward fix.

https://dev.gitblit.com/tickets/gitblit.git/134

Original comment by James.Mo...@gmail.com on 4 Jul 2014 at 3:46

GoogleCodeExporter commented 9 years ago 
Fix pushed to master.

Original comment by James.Mo...@gmail.com on 8 Sep 2014 at 5:58

GoogleCodeExporter commented 9 years ago 
In fact, I think this also affects group membership, i.e. if I remove someone 
from the LDAP git admin group, the user remains an admin in Gitblit even after 
re-login.

But I may be confusing things, I'll have to re-check tomorrow.

Original comment by sundayfu...@outlook.com on 8 Sep 2014 at 6:00

GoogleCodeExporter commented 9 years ago 
Okay, NVM the previous comment, I guess I was too quick testing this and the AD 
DCs were still busy replicating the update or something. It works fine.

Original comment by sundayfu...@outlook.com on 9 Sep 2014 at 12:19

GoogleCodeExporter commented 9 years ago 
v1.6.1 released

Original comment by James.Mo...@gmail.com on 20 Oct 2014 at 9:36