search

davideuler / gitblit

Automatically exported from code.google.com/p/gitblit
Apache License 2.0
0 stars 0 forks source link

Allow wildcards for indexed branch specification #473

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Hi!

I've sent you a patch on github that allows to select Lucene indexed branches 
via wildcards (for example, index all branches).

https://github.com/gitblit/gitblit/pull/211

Can you review and merge it? :)

Also -- maybe you can remove CRLF line endings from git repository and use eol 
setting in .gitattributes so everyone could get native line endings?

Original issue reported on code.google.com by vita...@yourcmc.ru on 28 Jul 2014 at 12:44

GoogleCodeExporter commented 9 years ago 
Sorry, been away. Still am, sort of.  I will merge your fix within the next 
couple weeks or maybe today - we'll see if I get distracted by other things - 
which is likely.

As for EOL, etc.  I agree.  It's total shit.  :)  Most development happens on 
the 'develop' branch and that is periodically merged into master on release 
(git-flow).  Before I release/merge 1.7.0 to master I will address the 
.gitattribute EOL thing.  This will of course generate a massive commit which 
will touch nearly every file.  :(

Git did a poor job on line-endings (we shouldn't have to think about this) and 
Eclipse's idiotic defaults on Windows don't help either.  But at the end of the 
day, it's still user (me) error.

Original comment by James.Mo...@gmail.com on 12 Aug 2014 at 6:51

GoogleCodeExporter commented 9 years ago 
Thanks for your answer :)

In fact I've realised my patch missed one thing - UI for editing this wildcard 
spec... Now the repository administration tool overwrites my wildcards if you 
select branches to index. I'll make a fix soon.

There is another small fix that I would also like to submit - 
https://github.com/vitalif/gitblit/commit/276dc646e1bec8745a3511fdf77ad5cb836f07
81 which makes gitblit include current object name in commits/tree/docs links. 
Not sure about docs, but at least for commits and tree it's the way that I 
expect repository navigation to work... i.e. for example I expect to stay in 
the branch I've clicked after going to "commits".

But I should probably detach that fix into its own branch and submit it as a 
separate pull request?

Original comment by vita...@yourcmc.ru on 12 Aug 2014 at 8:58

GoogleCodeExporter commented 9 years ago

Original comment by James.Mo...@gmail.com on 17 Sep 2014 at 7:10