davideuler / gitblit

Automatically exported from code.google.com/p/gitblit
Apache License 2.0
0 stars 0 forks source link

navigation links in repository view do not respect branch or tag context #501

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Open the commit log of a branch (not the default one) of a repository (i.e. 
https://dev.gitblit.com/log/gitblit.git/refs!heads!develop)
2. In the navigation bar switch to "tree" tab

What is the expected output? What do you see instead?
What I expect: tree view of the current branch I am looking at (i.e. tree of 
branch "develop": https://dev.gitblit.com/tree/gitblit.git/refs!heads!develop)
What I get: tree view of default branch (i.e. 
https://dev.gitblit.com/tree/gitblit.git)

This relates to most of the links in the navigation bar of a repository. In my 
opinion "commits", "tree", "documentation" links should refer to the current 
branch.

What version of the product are you using? On what operating system?
1.6.0; debian 7.0

Please provide any additional information below.
This is a controversial issue as there seems to be a concept behind the 
navigation rules. Some more information is probably needed for the context of 
the links in the navigation bar, say i.e. some hint in a mouseover to which 
"branch / tag / ref" you are switching by clicking a link button. Maybe an 
additional info box, showing the current branch, tag or ref one is surfing, 
should be added to the repository views. 

See also issue #473 (http://code.google.com/p/gitblit/issues/detail?id=473): 
there is a patch suggesting the change proposed here (needs confirmation)

Original issue reported on code.google.com by stephan....@googlemail.com on 11 Sep 2014 at 7:53

GoogleCodeExporter commented 9 years ago
The patch for the ref preservation makes some unnecessary changes and - like 
the wildcard patch - is clustered with completely unrelated changes.

I agree that the tree, commits, and docs links could/should preserve the ref.

Original comment by James.Mo...@gmail.com on 11 Sep 2014 at 2:18

GoogleCodeExporter commented 9 years ago
Fix merged to master.

The current commit id will be respected & preserved in the "commits", "tree", 
and "docs" links *if* the id resolves to a branch or tag.  If the commit id 
does not resolve to a branch or tag, then the id is ignored and those links 
will resolve to the default branch; same as before.

Original comment by James.Mo...@gmail.com on 12 Sep 2014 at 1:27

GoogleCodeExporter commented 9 years ago
v1.6.1 released

Original comment by James.Mo...@gmail.com on 20 Oct 2014 at 9:36