Don't offer disabled transport methods under preferences

[GoogleCodeExporter]

Thanks for another solid update, running 1.6.1 already!

Now I'd like to ask for a rather cosmetic change. The "Transport Preference" 
setting under "preferences" of the user page offers all 4 transport options 
regardless of git.acceptedPushTransports. I'm pretty Gitblit falls back to the 
correct option under the hood, but it's rather confusing nevertheless so it'd 
be handy to only show the methods that are actually enabled.

Original issue reported on code.google.com by sundayfu...@outlook.com on 24 Oct 2014 at 1:50

[GoogleCodeExporter]

Original comment by James.Mo...@gmail.com on 24 Oct 2014 at 12:03

• Changed state: Accepted
• Added labels: Milestone-1.7.0

[GoogleCodeExporter]

Actually, it already excludes disabled transports BUT it does not consider 
accepted PUSH transports.

I'm confident there are many installations where a user may only have clone 
access to Gitblit and by only considering accepted PUSH transports this would 
handicap their experience and generate complaints.

Original comment by James.Mo...@gmail.com on 31 Oct 2014 at 1:30

• Changed state: WontFix

[GoogleCodeExporter]

I can't confirm that either. I have server.httpsPort = 0 yet it offers 4 
transport methods (GIT, HTTP, HTTPS, SSH) on the GUI, and actually only 2 of 
them works for cloning (GIT, HTTP). The other 2 won't even affect the 
repository url when re-opening a repo page.

Original comment by sundayfu...@outlook.com on 31 Oct 2014 at 1:59

[GoogleCodeExporter]

Ah.  I'm looking at the 1.7.0 code, not 1.6.x.  That will only show enabled 
transports except...

http/https is tricky because of the GO/WAR split & reverse proxies.  That would 
require a new setting to handle WAR and/or reverse proxies.

Original comment by James.Mo...@gmail.com on 31 Oct 2014 at 2:20

[GoogleCodeExporter]

Oh I see, thanks for the explanation :)

Original comment by sundayfu...@outlook.com on 31 Oct 2014 at 2:29

[GoogleCodeExporter]

I pushed an improvement for GO.  I'm going to sit on WAR.

Original comment by James.Mo...@gmail.com on 31 Oct 2014 at 2:38

[GoogleCodeExporter]

Nice!

Original comment by sundayfu...@outlook.com on 31 Oct 2014 at 2:49