davidfcarr / rsvpmaker

RSVPMaker Events and Registration Plugin for WordPress
Other
13 stars 6 forks source link

Text escaping issue: lots of backslashes in confirmation email invite #25

Open xenotropic opened 6 months ago

xenotropic commented 6 months ago

I just did a test invite and at least Thunderbird I'm seeing lots of characters being escaped (double-escaped?) somehow; this breaks the URLs. The computer nerds would figure it out, but not the normal people. Any idea why this is happening?

image

xenotropic commented 6 months ago

Also the confirmation email subject lines seem to be URL encoded when they should not be

image

davidfcarr commented 6 months ago

I think I fixed the issue with HTML entities showing up in the subject line as shown above by switching to a WordPress specific function wp_specialchars_decode rather than a general PHP function. Not seeing the issue with backslashes. Can you provide an example of that?

davidfcarr commented 6 months ago

Sorry, what are you showing in the first screenshot? That looks like output from the ICS file attachment. I confess I haven't tested with Thunderbird, but I don't normally see that displayed. GMail would display it as a calendar invite.

xenotropic commented 6 months ago

That's a screenshot of Thunderbird showing the ics; you can also see where colons are getting escaped in the raw text of the ics (this is the ics file opened in gedit, text editor)

image