search

davidferguson / pibakery-blocks

All the blocks for the Pi Bakery program
GNU General Public License v3.0
242 stars 86 forks source link

Catagories + alias blocks #11

Closed dan3008 closed 8 years ago

dan3008 commented 8 years ago

Added a beta category for block testing. I have used this personally, but I understand its not everyone's first choice.

lurch commented 8 years ago

IMHO when you're trying to add two things at once ("Categories" and "alias blocks") it's better to do that in two separate PRs. (with each PR coming from a separate branch in your cloned repo) It keeps things cleaner (one commit per associated change), and it allows the project maintainer to optionally choose to merge one part without the other.

All IMHO of course... :-)

davidferguson commented 8 years ago

I agree with @lurch - it would be better if you could create two separate pull requests for this rather than just the one. However, I'm actually not sure if having a "beta category" in this repo is a good idea, as this is the code that I push out as PiBakery block updates, and I obviously don't want end users seeing that.

dan3008 commented 8 years ago

Sorry about that, I'm still new to github, or any group programming to be honest. As for beta, I just added that because its something I like to use. I'll split it off and just submit the alias blocks. I'll remove this fork, and start again