davidferguson / pibakery-blocks

All the blocks for the Pi Bakery program
GNU General Public License v3.0
242 stars 86 forks source link

newcronjob block failing to create job correctly #65

Closed IronBeard closed 6 years ago

IronBeard commented 7 years ago

I have been attempting to use the newcronjob block in my Pi builds. However it has not been creating the job correctly, if any of the first 5 fields are left as default then instead of passing the default (*) it passes the directory listing.

Example: /boot/PiBakery/blocks/newcronjob/newcronjob.sh 0 0 "*" "*" "*" '/home/pi/bginfo Nemesis "NAS" 0' pi >>/boot/PiBakery/firstboot.log 2>&1 || true

su - pi -c (crontab -l ; echo 0 0 createjob.sh newcronjob.json newcronjob.sh createjob.sh newcronjob.json newcronjob.sh createjob.sh newcronjob.json newcronjob.sh /home/pi/bginfo Nemesis "NAS" 0) | crontab -

This looks to be because the command line is expanding the out instead of passing the in to the command.

IronBeard commented 7 years ago

This is definately fixed by the code submitted by stevethomas in pull request #50

50 opened on Nov 14 2016 by stevethomas

davidferguson commented 6 years ago

Apologies for the delay, this fix is now in the repo and will be pushed out to PiBakery shortly.