search

davidferguson / pibakery-blocks

All the blocks for the Pi Bakery program
GNU General Public License v3.0
242 stars 86 forks source link

Created new block supporting enterprise wpa2 #81

Open DTV96Calibre opened 6 years ago

DTV96Calibre commented 6 years ago

I tried integrating this into the existing block but there were issues and the interface wasn't great. This is cleaner.

DTV96Calibre commented 6 years ago

I realized a while back that this pr isn't functional for a few reasons. Anyone interested in finishing this should do so before merging

littleblackfish commented 6 years ago

So what did you realize was missing? If you give me a list I'd like to polish it up.

DTV96Calibre commented 6 years ago

The primary thing is that it's not listed under info.json under load order, which is a simple fix. I remember being unhappy with the way the block was separate from the main wifi block and there wasn't an easy way to make the dropdown menus dependent on selected options. I think there were other issues (likely code related), but I had moved on due to time constraints and don't remember what was wrong.

littleblackfish commented 6 years ago

And I suppose the reason you didn't like the modification to the main wifi block was that the number of arguments are different, right?

DTV96Calibre commented 6 years ago

I don't mind increasing the number of arguments. The issue is that without figuring out how to hide individual input fields in the block, you'll end up with two "password" fields which serve different purposes and a username field which you shouldn't use unless you're doing enterprise WPA2. They could always ignore the extra fields but it was going to be confusing to most people, especially those who are looking for such a user friendly way to customize their Pi's OS installation.

DTV96Calibre commented 6 years ago

If you kept the blocks separate, this is pretty much a non-issue.