search

davidferguson / pibakery

The blocks based, easy to use setup tool for Raspberry Pi
http://www.PiBakery.org
GNU General Public License v3.0
1.48k stars 146 forks source link

raspbian/block update fails when only one OS is installed #135

Closed davidferguson closed 5 years ago

davidferguson commented 6 years ago

Found by @Barry4679 in #132

The checkForRaspbianUpdates function does not call the callback function if only Raspbian Full (so not Raspbian Lite) is installed.

Line 367 of pibakery.js skips to the next loop if the current image isn't installed. However, it is later on in the same loop on lines 394-396 that the function checks if we are at the end, and calls the callback.

Therefore, as the loop will skip when Raspbian Lite is not installed, the callback will never be called.

davidferguson commented 5 years ago

PiBakery v2 no longer bundles the images with the program, meaning that the update functionality has been removed and this is no longer an issue.