search

davidfig / pixi-cull

a library to visibly cull objects designed to work with pixi.js
MIT License
112 stars 15 forks source link

Adding Types to pixi-cull #13

Closed AdrienLemaire closed 3 years ago

AdrienLemaire commented 3 years ago

[tsserver 7016] [E] Could not find a declaration file for module 'pixi-cull'. /path/to/project/node_modules/pixi-cull/dist/index.js' implicitly has an 'any' type. Trynpm i --save-dev @types/pixi-cullif it exists or add a new declaration (.d.ts) file containingdeclare module 'pixi-cull';`

DefinitelyTypes doesn't have have type file for pixi-cull. But it'd be better to have the types directly in this repo. Like pixi-viewport does.

Thanks a lot for making this. Very useful <3

davidfig commented 3 years ago

I usually don't code in typescript. If you're willing to submit a PR or send me the types file, I can add it.