search

davidfig / pixi-viewport

A highly configurable viewport/2D camera designed to work with pixi.js
https://davidfig.github.io/pixi-viewport/
MIT License
1.04k stars 173 forks source link

Rotation support pixi-viewport #342

Open slyduda opened 2 years ago

slyduda commented 2 years ago

"Rotation isn't supported by the viewport b/c it breaks some of the plugins. You can rotate objects within the viewport, though."

Originally posted by @davidfig in https://github.com/davidfig/pixi-viewport/issues/334#issuecomment-925215514

Hi! Looking to add rotation support! I added a few comments in another thread. Rotating the viewport is essential for my project and I'm willing to tackle this as I know open source maintainers are busy! Would you be willing to point me in the direction of finding the plugins that are impacted by rotation (if you have the time).

Here is the other thread in which I commented: https://github.com/davidfig/pixi-viewport/issues/280#issuecomment-923162891

davidfig commented 2 years ago

Awesome! Most of the user input ones will be impacted by rotation: drag and pinch being the main ones. There are a bunch of utility functions in viewport.ts that might also need updating. You'll have to play with it and see what's working. Maybe add the rotation to the pinch plugin, or keep it separate. It would also be nice to have a separate drag to rotate plugin as well. Let me know if you run into any problems.

Veldrovive commented 2 years ago

This is also important to my project and, while I could work around it, I would like to have an official solution. Is this still something you are working on? If not, is there a fork with a start on it or some advice for pitfalls? I'd be happy to help out where I can.

nmichlo commented 1 year ago

This would be incredibly useful!

davidfig commented 1 year ago

This is not something I'm actively working on. But happy to take PRs.