Pixi v8 compatibility - Githubissues

davidfig / pixi-viewport

A highly configurable viewport/2D camera designed to work with pixi.js

https://davidfig.github.io/pixi-viewport/

MIT License

1.04k stars 174 forks source link

Pixi v8 compatibility #480

Closed vitch closed 5 months ago

vitch commented 6 months ago

This PR builds on #468 so that I can install it in my app locally...

Inside my app, setting the relevant package.json entry to:

"pixi-viewport": "git+https://github.com/vitch/pixi-viewport#pixi-v8",

Pulls in this branch and let's me continue upgrading my app to v8...

vitch commented 6 months ago

See also #481 if you have issues with yarn and this branch...

oliver-io commented 5 months ago

Any news on this? I've been using the branch from @vitch due to compat issues with v8.

AZ604 commented 5 months ago

yeah, please merge

adam-savard commented 5 months ago

I'll echo that we're also using this branch for our stuff due to incompatibility issues!

spassvogel commented 5 months ago

@davidfig what are your thoughts? can this be merged?

ArthurTimofey commented 5 months ago

Works great on our end with this branch, using the package.json git url for now but would be nice to merge, happy to help with anything in that regard, thanks for the great work.

davidfig commented 5 months ago

Merged #483, which I think does the same thing. Let me know if there are additional needed changes.

spassvogel commented 5 months ago

Merged #483, which I think does the same thing. Let me know if there are additional needed changes.

Yes in fact I think @TimAstier had a good point here?

https://github.com/davidfig/pixi-viewport/pull/468/files#r1514200010

spassvogel commented 5 months ago

also this commit f4cc203abd5901914a90b1578fe6eda3ec8aea48 might be good?

muhajirdev commented 4 months ago

how did you guys got it to work?

On my side I am getting this error