search

davidfig / pixi-viewport

A highly configurable viewport/2D camera designed to work with pixi.js
https://davidfig.github.io/pixi-viewport/
MIT License
1.04k stars 174 forks source link

Switch `yarn` for `npm` #481

Open vitch opened 6 months ago

vitch commented 6 months ago

(targets #480 - only the last commit on this branch is relevant but I couldn't see how to target another branch on my fork?)

The current setup requires yarn to be installed in order to build this repo.

For the pixi-v8 branch I'm pointing my app directly at the branch via:

"pixi-viewport": "git+https://github.com/vitch/pixi-viewport#pixi-v8"

This works fine locally (where I installed yarn) but fails on CI. So this commit attempts to remove the dependency on yarn.

Note I also had to lock electron to a version compatible with the peerDependency declared by floss (which afaict is the only reason electron is here).

vitch commented 6 months ago

This is working OK in my project in that I can point at this branch and CI can now build pixi-viewport (necessary because I need to point my app at the changes from #480).

I'm aware that these changes could be subjective and I'm not necessarily asking for them to be merged. The usage of yarn would be a non-issue for me if I wasn't pointing at a branch for pixi v8 support...