search

davidfischer / mtg-printable-set-label-generator

Magic: the Gathering Printable Set Label Generator
https://mtg-label-generator.fly.dev
MIT License
42 stars 12 forks source link

Code re-write to generate full set dividers #26

Closed smithjw closed 8 months ago

davidfischer commented 8 months ago

Did you decide to break this into a separate project? It was a little unclear exactly what the end product of this change was so it was kind of daunting to review.

smithjw commented 8 months ago

Sorry about this one David. I'd initially thought to open a PR against your original repo but given the large number of changes and how the fork was diverging, I opted to close and just continue work on my own copy.

My version of your original code is designed to generate full label cards that can be printed on thick paper/card stock to form an entire divider/label rather than printing and then sticking onto plastic/card dividers.

I really appreciate your initial repo as it gave me a great jumping off point.

I've also started initial work on a CSV import feature so that a user can export their MTG card collection from an app like Lion's Eye (iOS) or Moxfield (web) and generate dividers automatically (including color pip dividers for larger collections).

image

image

davidfischer commented 8 months ago

That's pretty sweet. In case anybody else wants something like that, the repo is here: https://github.com/smithjw/mtg-printable-set-label-generator

smithjw commented 8 months ago

I think the next step is to take a similar jump that you did and also have a web front-end to lower the barrier to entry ☺️