search

davidfowl / AspNetCoreDiagnosticScenarios

This repository has examples of broken patterns in ASP.NET Core applications
7.92k stars 750 forks source link

Copy Paste error in AsyncGuidance.md #111

Closed gakera closed 6 months ago

gakera commented 11 months ago

Not sure what a better header text would be, but "❌ BAD This example uses Task.Result to get the connection in the constructor. This could lead to thread-pool starvation and deadlocks." is copy pasted in this section: https://github.com/davidfowl/AspNetCoreDiagnosticScenarios/blob/master/AsyncGuidance.md#windowsidentityrunimpersonated

from this section: https://github.com/davidfowl/AspNetCoreDiagnosticScenarios/blob/master/AsyncGuidance.md#constructors

and the context doesn't make sense.

image

davidfowl commented 6 months ago

Fixed in https://github.com/davidfowl/AspNetCoreDiagnosticScenarios/pull/114