davidfowl / AspNetCoreDiagnosticScenarios

This repository has examples of broken patterns in ASP.NET Core applications
7.69k stars 740 forks source link

async void example won't compile #21

Closed jchannon closed 5 years ago

jchannon commented 5 years ago

In https://github.com/davidfowl/AspNetCoreDiagnosticScenarios/blob/master/AsyncGuidance.md under "Async Void" the example code snippet won't compile anyway

davidfowl commented 5 years ago

Not sure what you mean. Are you talking about missing functions? Or something else?

jchannon commented 5 years ago

In the example:

        public async Task BackgroundOperationAsync()
        {
            var result = await CallDependencyAsync();
            return result + 1;
        }

This won't compile

davidfowl commented 5 years ago

Send a PR?