search

davidfowl / AspNetCoreDiagnosticScenarios

This repository has examples of broken patterns in ASP.NET Core applications
7.69k stars 740 forks source link

Add notes for ConfigureAwait. #61

Open aholmes opened 4 years ago

aholmes commented 4 years ago

Filled out the TBD under ConfigureAwait. Tried to stick to the formatting, verbiage, and style of the rest of the article. Added examples from ASP.NET Framework.

vchirikov commented 4 years ago

asp.net core doesn't have SynchronizationContext

aholmes commented 4 years ago

@vchirikov indeed! I addressed this on line 612 of the first commit (609 of the final PR).

vchirikov commented 4 years ago

I mean it's very strange to mix up info about asp.net and asp.net core in repository with name AspNetCoreDiagnosticScenarios.

aholmes commented 4 years ago

Fair point. I'll think about revising so it's more relevant.

vchirikov commented 4 years ago

Also you can include useful info from Stephen Toub