search

davidfowl / Micronetes

Micronetes is a local orchestrator inspired by kubernetes that makes developing and testing microservices and distributed applications easier.
MIT License
773 stars 46 forks source link

Improve handling of stderr output #41

Closed nj0yeh closed 4 years ago

nj0yeh commented 4 years ago

Improve handling of stderr output.

Write correct error message when the build fails.

davidfowl commented 4 years ago

2 things:

nj0yeh commented 4 years ago 
* Take a look at this PR that just went in [afe111b](https://github.com/davidfowl/Micronetes/commit/afe111b06c73c2360cad8055f367037be5ec710f)

I am aware of it and talked to the author. I think my solution is a little bit cleaner (and it solves the error of not displaying the build error messages).

* Redo the commits to be based on master without all the merges.

Done.

davidfowl commented 4 years ago

I am aware of it and talked to the author. I think my solution is a little bit cleaner

From an API POV sure but it doesn't change the experience, the output is interleaved into a single output stream. The previous solution does this by default so all process launches were capturing both stdout and error. This only turns it back on for process launches for the project executable.

(and it solves the error of not displaying the build error messages).

Yep this PR has 2 different changes.