search

davidfrantz / force

Framework for Operational Radiometric Correction for Environmental monitoring
GNU General Public License v3.0
172 stars 50 forks source link

landsatlinks integration #235

Closed ernstste closed 1 year ago

ernstste commented 1 year ago

This PR is part of the landsatlinks integration as force-level1-landsat, related PR: https://github.com/davidfrantz/base_image/pull/2.

  1. remove the deprecated force-level1-landsat from makefile
  2. make landsatlinks available as force-level1-landsat in Docker
  3. update the print that is shown when force is run without arguments (I noticed it still was prinitng your old email and took the liberty to change that as well)
davidfrantz commented 1 year ago

Hey Stefan,

I am wondering wether we could skip the Dockerfile cp command, and instead put the cp into the Makefile (instead of deleting). This would also account for the non-Docker installation. What do you think?

ernstste commented 1 year ago

Hi David,

sure, go ahead 👍

davidfrantz commented 1 year ago

OK, I made the changes in the dev branch, and will reject this one accordingly. Thanks Stefan!

There are still four things to do:

1) version history 2) change docs of level1-landsat, and add installation instructions for landsatlinks to dependencies 3) update force-schedule 4) release next version

Could you please look at 1-3?

Thanks, David

ernstste commented 1 year ago

Thanks David

I'll look into 1 and 2 in the coming days. Our version of force-schedule has been updated, you can see it here https://github.com/Humboldt-EOLab/force-schedule. It's probably a better idea if you can adapt your version on your end. I wouldn't be able to check the changes in production on my end.