davidfrantz / force

Framework for Operational Radiometric Correction for Environmental monitoring
GNU General Public License v3.0
174 stars 50 forks source link

add s1 indices #287

Open felixlobert opened 1 year ago

felixlobert commented 1 year ago
davidfrantz commented 1 year ago

Hi Felix,

thanks for the contribution. However, the checks were not successful. There seem to be some syntax errors. Please also take a look at the comment with the math include.

In addition, please be aware that there is a working branch under development, which may cause merge conflicts at a later stage: https://github.com/davidfrantz/force/tree/external_tables However, as I currently don't have time to work on this branch, this should not be a reason to not accept your PR at this time. Nevertheless, the routines for computing indices will change in the future as there will be an external table that defines wavelengths for each index.

Cheers, David