search

davidfrantz / force

Framework for Operational Radiometric Correction for Environmental monitoring
GNU General Public License v3.0
172 stars 50 forks source link

Fix use of non-existing bash variable #300

Closed oceanites closed 1 year ago

oceanites commented 1 year ago

I apparently misconfigured the gsutil configuration and the .boho credentials file cannot be found. When investigating I noticed that the variable is likely wrong, which is fixed in this commit. Also puts the output in ', as first I misread the sentence end dot with a linux current directory dot.

ernstste commented 1 year ago

Thanks @oceanites, looks good! Changes to the code usually go into the dev branch before being merged into the main branch. @davidfrantz the code is ok to merge, let us know if you'd like a new PR for the dev branch first.

davidfrantz commented 1 year ago

Thanks both! And yes, could you please resubmit as a change in the dev branch?

Please see here for additional details: https://github.com/davidfrantz/force/blob/main/CONTRIBUTING.md#contributing-code-changes

oceanites commented 1 year ago

Thanks for the replies and sorry for not reading the contributing guide first and trying to merge directly into main. I submitted a new pull request for the develop with that change: #303