Carl ansi part1

[ccodere]

Let us try again : This is part 1 of the ANSI conversion, i could not do it in a smaller chunk than this.

Next steps:

• Adapt the lua scripts to use the new sed scripts.
• Continue base ansi C conversion of other compilers.
• Add more testing on C compiler recompilation with different flags.

Later on:

• Get rid of system as much as possible.

Next steps should be smaller than this one.

[ccodere]

I will look into it tomorrow, this was building on my machine, but after the merge with the head and latest changes i get on my local machine also:

[davidgiven]

Wow, this was a tonne of work! Thanks very much. I've gon through it and left a few minor comments. LGTM in general.

My biggest remaining concern is that it's too big, and is doing three different things: doing the ansification, adding part of a cmake setup, and replacing some of the source generation scripts.

Could you please move the cmake stuff and the script refactoring into different PRs? The cmake stuff is only partially complete and isn't ready for merge. The new scripts aren't hooked into the build.lua build system, so they're not used anyway, which means they shouldn't be here. We want to ansification stuff to be as simple and mechanical as possible.

But thank you for doing all this! It's really useful.

[ccodere]

Could you please move the cmake stuff and the script refactoring into different PRs? The cmake >stuff is only partially complete and isn't ready for merge. The new scripts aren't hooked into the >build.lua build system, so they're not used anyway, which means they shouldn't be here. We want to >ansification stuff to be as simple and mechanical as possible.

Done, normally CMake stuff and sed scripts are completely removed, not sure if git automatically removes the scripts directory though.

[davidgiven]

Thanks! That's merged --- it looks great. It's a substantially cleaner compile now, too.