Carl ansi part1 - Githubissues

davidgiven / ack

The Amsterdam Compiler Kit

http://tack.sf.net

Other

421 stars 59 forks source link

Carl ansi part1 #173

Closed ccodere closed 5 years ago

ccodere commented 5 years ago

Summary of changes in this pull request: Pascal compiler:

ANSI C conversion
Cleanup to reduce number of warnings.
fix some wrong tab/space issues

ANSI C compiler:

Bugfix of bug on fprint in error reporting in C compiler from last pull request (wrong file handle)
Some small cleanup to reduce number of warnings.

What is the policy for the C code in general? BSD Allman is ok with tabs or spaces? Seems existing code uses tabs, right?

davidgiven commented 5 years ago

I haven't had a chance to look through this yet, but re formatting there's a clang-format file in the root.

ccodere commented 5 years ago

I haven't had a chance to look through this yet, but re formatting there's a clang-format file in the root.

Thanks for the information, it gave me the time to fix 2 issues in my pull request.

davidgiven commented 5 years ago

Looks fine to me --- thank you very much! The entire build log now fits in the Travis console, at least for Linux... and that hasn't happened for a long time!