search

davidgiven / ack

The Amsterdam Compiler Kit
http://tack.sf.net
Other
420 stars 59 forks source link

Fewer clang warnings #211

Closed kernigh closed 4 years ago

kernigh commented 4 years ago

These commits silence some warnings when I use clang 8.0.1 on OpenBSD 6.6 to build ACK. They include changes to declare several functions before calling them, to add return types (often void) to functions, to fix types in printf() calls (by changing format strings or casting arguments), to add extra parentheses or braces. Some other changes (like adding static) don't fix any warnings.

The most unusual change in is commit 51e34ac, where I modified topgen to add a new syntax to declare functions before calling them. In 3f3bf1e, I tricked clang by hiding a printf() call in another function.

The commit be1662d fixes bug #188.

davidgiven commented 4 years ago

Thanks very much for that. One day I'm hoping that I'll be able to do a build and not have the error messages overflow my terminal scrollback buffer...