search

davidgiven / ack

The Amsterdam Compiler Kit
http://tack.sf.net
Other
420 stars 59 forks source link

Add .seek asm pseudo-op, advances location counter to fixed offset #227

Closed tkchia closed 3 years ago

tkchia commented 3 years ago

The new .seek assembler pseudo-op advances the location counter to a fixed offset within a section --- or to a fixed address, if the section is a .base'd section. It works somewhat like the GNU assembler's .org pseudo-op, though with a hopefully less confusing name.

This pseudo-op lets us avoid having to manually compute the needed boot sector padding in the pc86 start-up code plat/pc86/boot.s.

davidgiven commented 3 years ago

That looks great, thanks --- can you add a description in man/uni_ass.6, please?

tkchia commented 3 years ago

Hello @davidgiven,

Thank you!

I have pushed a commit to add a brief description of the new .seek pseudo-op to uni_ass(6). I also edited the description of the .base pseudo-op to match the implementation. Do let me know if there are any issues.

davidgiven commented 3 years ago

LGTM!

tkchia commented 3 years ago

Hello @davidgiven,

Incidentally — I am curious — is there any particular reason the uni_ass(6) man page (and some other man pages) are not installed in the $(INSDIR) staging area by default?

Thank you!

davidgiven commented 3 years ago

Um... probably not?

That file's generic to all the assemblers, and I see there's no build rule where that would go, so it probably just slipped through the cracks.