davidgohel / flextable

table farming
https://ardata-fr.github.io/flextable-book/
554 stars 79 forks source link

[docs] update add_footer's documentation #575

Closed jhk0530 closed 11 months ago

jhk0530 commented 11 months ago

Hi, thanks for nice work.

Recently I'm develop some package with flextable. and trying to add Footer like below's image (from function reference)

but I think this result can build with footnote function instead of add_footer. (also examples code generates another table)

here's add_footer's result with example code.

image

So here's my suggestion.

  1. Add note for footnote function below that image. (like See Also)

or

  1. Move that image to footnote's documentation. and update code for that.

If this make sence, I'd like to make PR for this.

Thanks.

Kim

davidgohel commented 11 months ago

hello, good catch, thank you

I did the update because it was a quick update, but thanks for volunteering for a PR.

Thanks, David

github-actions[bot] commented 5 months ago

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.