search

davidgohel / flextable

table farming
https://ardata-fr.github.io/flextable-book/
554 stars 79 forks source link

Update `set_formatter()` documentation #585

Closed davidgohel closed 9 months ago

davidgohel commented 10 months ago

Discussed in https://github.com/davidgohel/flextable/discussions/584

Originally posted by **sfcheung** November 6, 2023 Hi all, I need to do something in a package that cannot be easily done with the `colformat_*()` functions. Using `set_formatter()` can solve my problem. Then I found that, according to the help page of `set_formatter()`, "This function will be deprecated in favor of the ⁠colformat_*⁠ functions ...". However, I noticed that some recent posts at GitHub (e.g., #572) still suggests using `set_formatter()`. Will `set_formatter()` be deprecated as planned? Or will it stay in the package? If I use `set_formatter()`, I will use it in a package. Therefore, if it will be deprecated as planned, I need to find another solution. Personally, I think `set_formatter()` is a good option for cases not covered by `colformat_*()`. I used these formatters a lot but having a Plan B (`set_formatter()`) is a good thing. -- Shu Fai
davidgohel commented 9 months ago

fixed in the manual with 81b14725e72adae1f546f952deed8d65c931a27d

There was a misunderstanding, we want to deprecate the set_formatter_type() function, not the set_formatter() function.

github-actions[bot] commented 2 months ago

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.