search

davidgohel / flextable

table farming
https://ardata-fr.github.io/flextable-book/
565 stars 82 forks source link

bring back shadow-dom for pagedown #666

Closed davidgohel closed 1 month ago

davidgohel commented 1 month ago 
          And this search lead me to this commit

I think that flextable now always output shadow dom, and #216 still applies because the ft.shadow option is not existing anymore in flextable (https://github.com/davidgohel/flextable/commit/439d93c55339b0d1ff7929fbfa80d470adf75308#diff-f0c168982bc3b1afb5f98bd5e0230be9a96126d723db777bfde5b3dfeacf9b00L1012)

@davidgohel I'll see what I can do in pagedown but if there is a way to still not use shadow dom in paged.js context, it would be cool.

Otherwise, it will need to wait for an update in Paged.js inside pagedown but I am not sure that paged.js really support shadow dom

So we may be blocked here. 🤔

Originally posted by @cderv in https://github.com/rstudio/pagedown/issues/332#issuecomment-2399912716

davidgohel commented 1 month ago

thanks @cderv and @yihui for helping me to close the evil 666 issue

yihui commented 1 month ago

You are welcome! I'll make a new CRAN release of pagedown soon.

cderv commented 1 month ago

the evil 666 issue

😆 I have not seen that one... Bringing back the shadows for the evil issue 😈

yihui commented 1 month ago

FYI pagedown 0.21 is on CRAN now.

davidgohel commented 1 month ago

Thank you @yihui