Open markheckmann opened 1 month ago
Hello,
I've been thinking about this and I think it's a good idea, it's similar to what we use for the ggplots position
argument, a parameterizable function or a simple string. You're welcome to implement it, of course, or I can help you (or do it myself) :)
I'm not a fan of the numerical index idea, but I'll leave the decision up to you.
David
@davidgohel Great, happy to do it. Please feel free to assign the issue to me :)
When I started out with officer, I was initially confused by the
ph_with
location
argument which expects the output of one of theph_location_*
functions. Now, all make perfect sense. Still I think it would be useful (especially for newcomers) to also offer the option of supplying a simplifiedlocation
arg input (string or numeric), instead of a having to call aph_location_*
function.Providing a string or numeric can - I think unambiguously and without loss of generality - cover most of the common
ph_location_*
use cases. While theph_location_*
functions allow for more customized settings and additional features, I think the simplified version would be a nice UI addition and suffice the most common use cases._NB: Behind the scenes, the simplified input would just be automatically plugged into one of the
ph_location_*
functions._What do you think?