davidgtonge / backbone_query

A lightweight query api for Backbone Collections
MIT License
378 stars 29 forks source link

Very similar to Query Engine #6

Open balupton opened 12 years ago

balupton commented 12 years ago

Very similar to Query Engine perhaps we should team up :) What are your thoughts?

Here is a comparison that I've done up:

davidgtonge commented 12 years ago

Hi, would be good to team up. I love what you've done with live collections. Query Engine definitely has more features although there are some from Backbone Query that we could perhaps port over, eg. querying computed properties, querying nested models / arrays.

What do you think is the best way to move forward ?

balupton commented 12 years ago

Hey David,

Thanks for your kind words. I definitely agree with you that porting over the missing functionality from Backbone Query into Query Engine makes the most sense (least effort, biggest reward).

In regards to who actually does the porting, it doesn't seem that particular, as long as we make ourselves available to each other to help out if someone gets stuck. On that note, you can add me on Skype (username balupton) or join the #bevry on freenode channel if you prefer IRC.

I've created the repo - https://github.com/balupton/query-engine-contrib - for us to work on (you've been added a contributor), so let's use a new branch called backbone-query-merge to do the porting. Once it's all stable, we'll pull the changes into the official repository :)

Good plan? Really excited about working together on this! :D Can't wait for the end result, it'll be spectacular!

davidgtonge commented 12 years ago

Hi Benjamin,

Thanks for the message. I'll have a look at porting some of the code over this weekend. Will try and connect via Skype / IRC also.

Thanks again

Dave

davidgtonge commented 12 years ago

Hi Benjamin,

I've had a look at the code this morning and think it would be good to chat about some of the code. What times are you normally available on Skype / IRC? Thanks. Before doing too much work on the code, I've been comparing the performance of the 2 libraries - food for thought: http://jsperf.com/backbone-query-vs-queryengine/2

balupton commented 12 years ago

Cool, looks like you made it a lot faster! Keen to see what you did.

I'm generally on Skype everyday from 10am to 10pm Sydney Time. However, can be on earlier (6am+) if need be.

balupton commented 12 years ago

Cool, I've merged that branch into the bevry repo. And just pushed v1.2.2 that adds the missing functionality from backbone query into query engine.

Didn't apply the refactorings around the query class, as wasn't sure what benefit they added...

balupton commented 12 years ago

I've updated the performance tests. QueryEngine same results. So I guess the refactorings you've done where for the speed increase... Will look into this some more.

davidgtonge commented 12 years ago

Hi, thanks for doing the merge. I've been on holiday, but should be able to help out a bit more now. I'll take a look at the code shortly.

charlotte-miller commented 12 years ago

Hey David - are you going to continue using and working on backbone_query?

davidgtonge commented 12 years ago

Hi Chip, yes I'm using backbone_query in production. I have some updates that I need to push and will do so shortly.