search

davidguttman / cssify

Simple middleware for Browserify to add css styles to the browser.
122 stars 19 forks source link

Add support for CSS Modules #27

Closed faergeek closed 8 years ago

faergeek commented 8 years ago

It's based off another PR right now, I hope you'll accept it before this one and I'll just rebase it :-)

davidguttman commented 8 years ago

Merged the other one, but might want to get some new tests going before putting this one in.

faergeek commented 8 years ago

Take a look please

faergeek commented 8 years ago

I have no idea how to report error with through. Why don't you use through2?

davidguttman commented 8 years ago

Pretty sure this predates through2, happy to switch.

davidguttman commented 8 years ago

Tests are passing, looks good to me =)

faergeek commented 8 years ago

There are minimal tests for the browser. I think it's enough to test generated source.

davidguttman commented 8 years ago

cssify@1.0.0 =)

faergeek commented 8 years ago

Cool :+1:

Could you please take a look at this? https://github.com/asbjornenge/stylusify/issues/2

I think it would be convenient to use some option for sassify transform to compose with cssify and may be something in between, what do you think?

davidguttman commented 8 years ago

If I understand correctly, sassify would no longer depend on cssify, but would just output css. Then the user could have anything after it (but most likely cssify). Is that right? On Fri, Nov 13, 2015 at 12:15 PM Sergey Slipchenko notifications@github.com wrote:

Cool [image: :+1:]

Could you please take a look at this? asbjornenge/stylusify#2 https://github.com/asbjornenge/stylusify/issues/2

I think it would be convenient to use some option for sassify transform to compose with cssify and may be something in between, what do you think?

— Reply to this email directly or view it on GitHub https://github.com/davidguttman/cssify/pull/27#issuecomment-156545368.

faergeek commented 8 years ago

You can save default behavior if you like it, but you could add some option so that it does not pipe it's output through cssify and just passes it to next transform, but what you suggest would be even better probably (I mean if it would behave that way by default) :+1: .

Would be cool if we could compose preprocessors for css in a more flexible way than now.