Tests

[faergeek]

I would like to setup some code style using eslint, did you use it or something like jscs/jshint?

I just generally do not understand code style (2 or 4 spaces, space before function keyword and such things).

[faergeek]

Also what about using ES6 with Babel or just a subset which is supported by latest Node?

[davidguttman]

If we do code style it should be https://www.npmjs.com/package/standard

As for ES6 I'd prefer not to pull in Babel, so either use the node subset or stay with ES5.

[faergeek]

Almost done writing tests, take a look, please :-)

[davidguttman]

Looking way better!

Since we're now using ES6, be sure to set "engines" in package.json: https://docs.npmjs.com/files/package.json#engines

If you want to avoid using the private tape method to show coverage, we can just put that it in it's own "test" at the end called "coverage" or whatever. tape will make sure it runs after everything else.

One minor thing -- the node convention is to use all lower case in file names. So lib/processCss.js should be lib/process-css.js.

Nice work!

[faergeek]

I would like it to be compatible with Node 4, will test a little later.

About using private method, it's not just to collect coverage, we should close the window after running tests. Without explicit window.close it just leaves it open and process waits.

Will fix filenames a little later, Thanks! :+1:

[faergeek]

Fixed filenames and added "engines" field. Not sure what to do about "private" interface of tape.

[davidguttman]

Not a big deal, fine with using the private interface.

In package.json did you mean to do "node" : ">= 4.0.0" instead of "npm" : ">= 4.0.0"?

[faergeek]

Yes, sorry, will fix it right now

[faergeek]

Done

[faergeek]

It's probably better to squash some commits, right?

[davidguttman]

Probably, want me to wait on that?

[faergeek]

Done

[davidguttman]

Nice work!

[faergeek]

Thanks, I'm going to add support for css modules now :-)