search

davidhalter / jedi-vim

Using the jedi autocompletion library for VIM.
MIT License
5.29k stars 370 forks source link

Only use buffer on rename and show usages #1020

Closed ethan-leba closed 4 years ago

ethan-leba commented 4 years ago

Here's my attempt on #1017. It's mostly working, the only issue I ran into is that the error E21: Cannot make changes, 'modifiable' is off always pops up before the quickfix list opens to show usages after refactoring. Other than that, it works, but I'm pretty stumped on this bug so I thought I'd just open the PR and see if any of the maintainers know what's going on here!

ethan-leba commented 4 years ago

Looks like master is failing CI

davidhalter commented 4 years ago

Master passed: https://travis-ci.org/github/davidhalter/jedi-vim/builds/659627955. Not sure if something on the CI changed.

However, I'm still pretty sure that this PR doesn't have anything to do with the failure, so we should probably just change this test (it has been annoying before). You don't have to do anything there, that's my responsibility.

ethan-leba commented 4 years ago

Sorry, worded that poorly. What I meant by that was that running tests on master locally failed for me

davidhalter commented 4 years ago

CI should be working smooth now (on master).