davidhalter / jedi-vim

Using the jedi autocompletion library for VIM.
MIT License
5.28k stars 370 forks source link

Neovim's virtualtext for call signatures #891

Open blueyed opened 5 years ago

blueyed commented 5 years ago

We could investigate using Neovim's virtualtext support for call signatures (https://github.com/davidhalter/jedi-vim/issues/890#issuecomment-444284185), which could be added to the end of the current line.

(https://github.com/davidhalter/jedi-vim/issues/890#issuecomment-444284185 reminded me of that)

blayz3r commented 5 years ago

Does the new Vim popup change anything? Syntax highlighting signatures maybe?

blueyed commented 5 years ago

Yeah, that would likely be even better to use. Neovim has it also (had it before, and Vim uses a different API again...).

davidhalter commented 5 years ago

I'm open to all those changes, but I'm still using old VIM, so feel free to change this.

blueyed commented 5 years ago

Started playing with using Neovim's floating windows. Based on https://github.com/davidhalter/jedi-vim/pull/652.

blueyed commented 5 years ago

Syntax highlighting signatures maybe?

It still uses the existing concealing (but in a separate window, not messing with the current buffer anymore, which might interfere with indenting etc).

davidhalter commented 3 years ago

We can do the same for VIM, using textprop, but we need at least patch 8.2.0286.

blueyed commented 3 years ago

Note: textprop is used for usages already: https://github.com/blueyed/jedi-vim/blob/6ca603ffdf989cfc7426485252a77529951ea47e/pythonx/jedi_vim.py#L658-L669