search

davidhalter / jedi

Awesome autocompletion, static analysis and refactoring library for python
http://jedi.readthedocs.io
Other
5.73k stars 503 forks source link

allow users to set cache_directory via env-var, #1965 #1966

Closed woutervh closed 9 months ago

woutervh commented 9 months ago

implements https://github.com/davidhalter/jedi/issues/1965

codecov-commenter commented 9 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
jedi/settings.py 86.36% <66.66%> (-3.64%) :arrow_down:

:loudspeaker: Thoughts on this report? Let us know!.

davidhalter commented 9 months ago

Now it's not documented anymore. Sorry I don't have the patience for this. I initially rejected this, so I'm going to close.

woutervh commented 9 months ago

what does the word "revert" mean in your dictionary?

woutervh commented 9 months ago

Python applications and certainly libraries should never write anything to hardcoded unconfigurable directories.

I don't understand your objection to such no brainer.