davidhalter / jedi

Awesome autocompletion, static analysis and refactoring library for python
http://jedi.readthedocs.io
Other
5.73k stars 503 forks source link

fix jedi-core passing sys_path from jediepcserver.py #1973

Closed plandes closed 7 months ago

plandes commented 7 months ago

The Emacs Jedi library creates a jedi.Script with a sys_path parameter. It appears this was removed in a more recent version. I have added the parameter to the class initializer and added any non-None paths to the Python sys.path list.

This fixes pip package versions higher than 0.17.2 for my set, which is: Emacs: 29.1 Jedi: 0.3.0 Python: 3.11.6 epc: 0.0.5 sexpdata: 1.0.0

codecov-commenter commented 7 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (f8e502f) 94.50% compared to head (67618fb) 94.43%.

:exclamation: Current head 67618fb differs from pull request most recent head ebbb9bc. Consider uploading reports for the commit ebbb9bc to get more accurate results

Files Patch % Lines
jedi/api/__init__.py 33.33% 4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1973 +/- ## ========================================== - Coverage 94.50% 94.43% -0.08% ========================================== Files 80 80 Lines 11917 11922 +5 ========================================== - Hits 11262 11258 -4 - Misses 655 664 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

davidhalter commented 7 months ago

This was intentionally removed (see also https://jedi.readthedocs.io/en/latest/docs/changelog.html#id8)

Use the Project API to configure sys paths now: https://jedi.readthedocs.io/en/latest/docs/api.html#projects

plandes commented 7 months ago

@davidhalter Thanks for the quick response. I'll try to address the issue from the Emacs library side. Thanks for writing this great library.

-Paul