search

davidhampgonsalves / hugo-black-and-light-theme

A High contrast, text oriented, performant and Javascript-free theme for Hugo.
https://themes.gohugo.io/themes/hugo-black-and-light-theme/
GNU General Public License v3.0
189 stars 94 forks source link

Same IDs re-used in multiple places #19

Closed hacklschorsch closed 4 years ago

hacklschorsch commented 4 years ago

Thank you for this very nice theme! I have adopted it for my personal blog.

I only now saw that this theme re-uses the same ID attribute for multiple elements, for example can I see <div id=date> multiple times in the source code of the theme demo page. This seems to not be valid HTML:

When specified on HTML elements, the id attribute value must be unique amongst all the IDs in the element's tree and must contain at least one character.

Probably one can exchange many of the id attributes by class attributes of the same value, change the CSS selectors to match, and be done with it.

The w3c html validator also recognizes this as a problem, plus some others. I can't say how bad any of those are, though.

This thread has a list of things that can go wrong when re-using IDs.

davidhampgonsalves commented 4 years ago

thanks, fixed