search

davidhatten / geometric-drawer

A little single-page javascript app to generate simple geometries and mandalas
0 stars 0 forks source link

Do *something* about `historyConstants` #31

Closed davidhatten closed 6 years ago

davidhatten commented 6 years ago

historyConstants is a bandaid that's gone too far. It's an object whose keys are all constants, referenced in the payload of a changeShapeHistory request. I didn't build this thing with tests (because getting an ES6 stack up and running from the ground up is exhausting enough before you try to figure out how to test JavaScript) and this is the result. I know those are untestable, there's no enforcement of the contract, so it needs to be fixed. I want it fixed before 1.3.0.

davidhatten commented 6 years ago

One possible solution is going into 1.3.0. More improvements could be made.