davidhealey / waistline

Libre calorie counter app for Android. Built with Cordova.
557 stars 66 forks source link

Keep the last choice set #640

Closed serrq closed 1 year ago

serrq commented 1 year ago

Each time I find myself having to set again the selection of what I want to display in the pie chart.

I therefore request that the app remember the last selection made.

Screenshot_2022-10-03-16-56-29-40_e8d03466a4604b1244d2695731a8e6b1 (1)

EmilJunker commented 1 year ago

The entries for fat and carbs in the pie chart don't include sat fat and sugar! So if you hide sat fat and sugar, the chart data is no longer correct!

Before rendering the chart, Waistline subtracts the amount of sat fat from the fat value and the amount of sugar from the carbs value. The slices for fat and sat fat combined show you the total proportion of fat, and the slices for carbs and sugar combined show you the total proportion of carbs. That's also the reason why the slices forming a pair each have similar colors.

To be honest, I'm surprised to hear that it's still even possible to hide individual nutriments from the chart. I was under the impression that this capability was disabled long ago 🤔.

serrq commented 1 year ago

Who cares to see the sugars and saturated fats in the pie chart?

I am surprised.

I mean it is not in the purpose of the pie chart to show minor nutrients; I just want to see the macro nutrients there.

EmilJunker commented 1 year ago

Who cares to see the sugars and saturated fats in the pie chart?

I do :) Not all carbs and fats can be treated equally. Sat fats and sugar are particularly bad for your health, and I appreciate the ability to see at a glance what proportion of the fats is saturated, and how many of the carbs are just plain sugar.

I just want to see the macro nutrients there.

That's exactly the reason why the slice for sat fat has almost the same color as the one for fat (same goes for carbs and sugars). If you don't care abour sat fats and sugar, you can simply treat the two red slices as one large slice for fat, and the two blue slices as one large slice for carbs. Does this really bother you that much?