Feature Request: Option to show/hide Brands in the Diary screen

[hellsend]

On small-ish screen size, with large-ish Android text size, the diary view gets a little bit clogged up for my key-user taste.

I suggest we add the option to show or hide the food/meal/recipe item brand in the diary screen, so that users who so wish can do away with this information on the Diary screen. This is only a Diary rendering modification, no database or "hard-structure" modification should be needed.

From what I've seen in the code, the implementation should be quite simple:

• Define the option for the first-time setup,
• Add the option in the settings/diary html page,
• Add the parameter in the foods/meals/recipe renderItem function and add the parameter condition on the Brand subtitle section,
• Initialize the variable & use it when calling the renderItem function in the diary/groups js page,
• Allow for translation of the Option in the settings.

I've tried to do that already in the code, and local (browser-based) & personal apk (app-debug.apk installed on my phone) testing has been successful.

I would like to create the pull request to implement these modifications.

I'm not sure about all of the translations, but I've tried to make them in line with the other "Show xxx" options in each localization file.

Feel free to give me some feedback on this, it's my first pull request on this codebase (maybe even my first ever github pull request?) and I'd like not to break everything :-)

Cheers, Hellsend-

[davidhealey]

Sounds good, let's see the code

[hellsend]

Just did that, and I'm impressed with your reaction time :-D (I'll try and not hold you up to this kind of standard in the future, I promise :-))

[davidhealey]

Looks good. I haven't tested it yet though.

The translations are handled through Crowdin, you only need to add strings directly to the locale-en file. Can you remove the other files from your PR? They will be overwritten by changes from Crowdin.

[hellsend]

Oh, well, yeah, let me just try and find out how to remove files from a commit and I'll push that right away :-)

[hellsend]

@davidhealey : Okay, after much (uneeded) suffering, and possibly some erasing of some modifications (comments?) made by @EmilJunker , I think the request #760 is more in line with what you mentioned.

Feel free to test around, I didn't have any problems (built locally with Gradle 7.6.3) on my end, to try and respect the Dockerfile instructions).